pkgs/p2p_core/src/primitives/mn_list.rs (1)

113-119: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Guard Evo/version invariants before serializing SimplifiedMnListEntry.

At Line 113, serialization can silently produce malformed bytes when mn_type == MnType::Evo but platform_http_port or platform_node_id is None. Also, version < 2 with non-regular mn_type can produce non-roundtrippable output. Please enforce these invariants before writing bytes.

💡 Minimal fail-fast guard (example)

 pub(crate) fn encode(&self, buf: &mut Vec<u8>) {
+  assert!(
+    self.version >= 2 || self.mn_type == MnType::Regular,
+    "mn_type requires version >= 2"
+  );
+
   buf.extend_from_slice(&self.version.to_le_bytes());
   buf.extend_from_slice(&self.pro_reg_tx_hash.to_bytes());
   buf.extend_from_slice(&self.confirmed_hash.to_bytes());
   buf.extend_from_slice(&self.service.addr);
   buf.extend_from_slice(&self.service.port.to_be_bytes());
   buf.extend_from_slice(&self.operator_key.0);
   buf.extend_from_slice(&self.voting_key_id.0);
   buf.push(u8::from(self.is_valid));
   if self.version >= 2 {
     buf.extend_from_slice(&self.mn_type.to_u16().to_le_bytes());
   }
   if self.mn_type == MnType::Evo {
-    if let Some(port) = self.platform_http_port {
-      buf.extend_from_slice(&port.to_le_bytes());
-    }
-    if let Some(ref nid) = self.platform_node_id {
-      buf.extend_from_slice(&nid.0);
-    }
+    let port = self.platform_http_port.expect("Evo entry missing platform_http_port");
+    let nid = self.platform_node_id.as_ref().expect("Evo entry missing platform_node_id");
+    buf.extend_from_slice(&port.to_le_bytes());
+    buf.extend_from_slice(&nid.0);
   }
 }

As per coding guidelines, "Use newtypes over primitives when semantics differ, enums over booleans, and make invalid states unrepresentable".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkgs/p2p_core/src/primitives/mn_list.rs` around lines 113 - 119, Before
emitting bytes in the SimplifiedMnListEntry serialization path, validate the
invariants: if self.mn_type == MnType::Evo then ensure
self.platform_http_port.is_some() and self.platform_node_id.is_some() and return
an error (or panic) if missing; likewise if self.version < 2 then ensure
self.mn_type == MnType::Regular (or return an error) so non-regular types aren't
serialized for older versions. Add these checks at the start of the
serialization routine (the impl that writes buf for SimplifiedMnListEntry) and
fail fast with a clear error message mentioning the field(s)
(platform_http_port, platform_node_id, mn_type, version) so malformed/
non-roundtrippable bytes are never produced.